Skip to content

[rewrite] add CodeCleanup#2813

Closed
Pankraz76 wants to merge 1 commit intodiffplug:mainfrom
Pankraz76:fix-JavaLangAPIs
Closed

[rewrite] add CodeCleanup#2813
Pankraz76 wants to merge 1 commit intodiffplug:mainfrom
Pankraz76:fix-JavaLangAPIs

Conversation

@Pankraz76
Copy link

@Pankraz76 Pankraz76 commented Jan 11, 2026 •
edited
Loading

[rewrite] add CodeCleanup

There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/eslint-package.json
There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/prettier-package.json
There were problems parsing lib/src/main/resources/com/diffplug/spotless/npm/tsfmt-package.json
All sources parsed, running active recipes: com.diffplug.spotless.openrewrite.SanityCheck
Changes have been made to testlib/src/main/java/com/diffplug/spotless/TestProvisioner.java by:
    org.openrewrite.staticanalysis.HideUtilityClassConstructor
Changes have been made to testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java by:
    org.openrewrite.staticanalysis.HideUtilityClassConstructor
Changes have been made to testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java by:
    org.openrewrite.staticanalysis.ForLoopControlVariablePostfixOperators
Please review and commit the results.
Estimate time saved: 15m

@Pankraz76 Pankraz76 marked this pull request as ready for review January 11, 2026 06:50
@Pankraz76 Pankraz76 changed the title [rewrite] fix JavaLangAPIs #2804 (#2810) [rewrite] add CodeCleanup Jan 11, 2026
Pankraz76
Pankraz76 commented Jan 11, 2026
View reviewed changes
Pankraz76
Pankraz76 commented Jan 11, 2026
View reviewed changes
@Pankraz76 Pankraz76 force-pushed the fix-JavaLangAPIs branch 4 times, most recently from 3266572 to 444fd43 Compare January 11, 2026 15:32
@Pankraz76 Pankraz76 marked this pull request as draft January 11, 2026 15:56
@Pankraz76 Pankraz76 marked this pull request as ready for review January 11, 2026 17:26
Pankraz76
Pankraz76 commented Jan 12, 2026
View reviewed changes
testlib/src/test/java/com/diffplug/spotless/PaddedCellTest.java
void cycleOrder() {
BiConsumer<String, String> testCase = (unorderedStr, canonical) -> {
List<String> unordered = Arrays.asList(unorderedStr.split(","));
for (int i = 0; i < unordered.size(); ++i) {
Copy link
Author

@Pankraz76 Pankraz76 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is not good for us, right? assuming we want to have all in same manner for simpler workflow.

@Goooler ?

testlib/src/main/java/com/diffplug/spotless/ReflectionUtil.java
* just copy-paste these methods where you need
* them.
*/
public class ReflectionUtil {
Copy link
Author

@Pankraz76 Pankraz76 Jan 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems obsolete

@Pankraz76 Pankraz76 mentioned this pull request Jan 12, 2026
Closed
@Pankraz76 Pankraz76 mentioned this pull request Jan 12, 2026
Merged
@Pankraz76
Copy link
Author

Pankraz76 commented Jan 17, 2026

again the maintainer does not give a damn anymore.

talking about etiquette instead of the real deal is not in my interest.

@Pankraz76 Pankraz76 closed this Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Pankraz76